Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for matrix server #65

Merged
merged 3 commits into from
May 27, 2022
Merged

add support for matrix server #65

merged 3 commits into from
May 27, 2022

Conversation

ahdekkers
Copy link
Contributor

@ahdekkers ahdekkers commented May 15, 2022

Description

Added matrix service

Fixes #61

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

@ahdekkers
Copy link
Contributor Author

Let me know if I should make any changes, @kha7iq

@kha7iq
Copy link
Owner

kha7iq commented May 24, 2022

@ahdekkers Sorry for the delay , i am swamped with some work these days.
Just a small thing, can you please confirm if you have tested sending messages to matrix server with the changes ?
Also can you please lint the code make lint and see if everything is good. I will merge afterwards

@ahdekkers
Copy link
Contributor Author

Hey, no worries. Yeah sending matrix messages work, I only used official matrix servers for the testing. The make lint isn't working for me - for some reason it tells me:
golangci-lint run ./... ERRO Running error: context loading failed: no go files to analyze make: *** [lint] Error 5
Same thing when I run golangci-lint run service/matrix. Have you encountered this before and does it work for you?

@kha7iq kha7iq merged commit 2e45005 into kha7iq:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(service): add support for matrix server
2 participants