Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust typing for xarray 2024.1.0 #114

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Adjust typing for xarray 2024.1.0 #114

merged 3 commits into from
Jan 22, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Jan 22, 2024

xarray 2024.1.0 was released 2024-01-17. Since then, the "Code quality" CI job has failed, for instance here, with mypy errors.

This PR fixes.

PR checklist

  • Checks all ✅
  • Update documentation No functional changes.
  • Update doc/whatsnew.rst

@khaeru khaeru self-assigned this Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b49e22) 100.00% compared to head (0a4bb8b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         4119      4118    -1     
=========================================
- Hits          4119      4118    -1     
Files Coverage Δ
genno/caching.py 100.00% <100.00%> (ø)
genno/compat/plotnine/plot.py 100.00% <100.00%> (ø)
genno/core/sparsedataarray.py 100.00% <ø> (ø)
genno/core/types.py 100.00% <100.00%> (ø)

@khaeru khaeru merged commit ac3ba5e into main Jan 22, 2024
20 checks passed
@khaeru khaeru deleted the typing/xarray-2024.1 branch January 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants