Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loop in individual method #9

Closed
miladezzat opened this issue Feb 27, 2021 · 1 comment
Closed

Make loop in individual method #9

miladezzat opened this issue Feb 27, 2021 · 1 comment
Labels
feature

Comments

@miladezzat
Copy link
Contributor

miladezzat commented Feb 27, 2021 •
edited
Loading

Problem

use loop inside constructor makes it not readable

Solution

create new method insertMany for inserting iterable elements to the array
@khaledosama999
Copy link
Owner

I don't mind it but insertArray is not the right name, I think insertMany is more accurate, You are more than welcome to make a PR for it

@miladezzat miladezzat mentioned this issue Feb 27, 2021
Closed
miladezzat added a commit to miladezzat/binary-heap.js that referenced this issue Feb 27, 2021
@miladezzat
chore: update package json
7991ac7 
"re khaledosama999#9"
miladezzat added a commit to miladezzat/binary-heap.js that referenced this issue Feb 27, 2021
@miladezzat
refactor: create inserMany method
fc75a1a 
"fix khaledosama999#9"
miladezzat added a commit to miladezzat/binary-heap.js that referenced this issue Feb 27, 2021
@miladezzat
chore: update package json
b4bf514 
"re khaledosama999#9"
@miladezzat miladezzat mentioned this issue Feb 27, 2021
Merged
miladezzat added a commit to miladezzat/binary-heap.js that referenced this issue Feb 27, 2021
@miladezzat
test: make test for insertMany
abbf20d 
"fix khaledosama999#9"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khaledosama999 @miladezzat