More efficient frame copying. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ Copyright (C) 2021 FreezeFrame | |||
|
|
|||
| ## Licenses For ImageSharp | |||
|
|
|||
| - This tool uses [ImageSharp](https://sixlabors.com/products/imagesharp/), which requires a license for commercial use. | |||
| - This tool uses [ImageSharp](https://sixlabors.com/products/imagesharp/), which requires a license for commercial support. | |||
There was a problem hiding this comment.
People can use the libraries commercially under the Apache license. They just can't ask me for any support unless they purchase a Six Labors license.
| THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
There was a problem hiding this comment.
Must be a line endings thing
Program.fs
Outdated
| image.[x,y] <- source.[x,y] | ||
| use gif = Image.Load(path) | ||
| use image = new Image<Rgba32>(gif.Width, gif.Height) | ||
| image.Frames.AddFrame(gif.Frames.RootFrame)|> ignore; |
There was a problem hiding this comment.
; is optional in F# in this case.
There was a problem hiding this comment.
Took me two reads to figure out what you meant there! 🤣
|
@JimBobSquarePants left an MR here showing how stream copying would be done, per your comment. |
stream copying
|
This is awesome. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just saw your tweet asking me for assistance with the ImageSharp API. This is my first time writing F# so I'm hoping I got it right!
I replaced the
[x, y]frame iteration with a more efficient cloning. I also fixed the leak for the initial gif.I did spot something else but I'm not confident in my F# to do a fix.
I wouldn't return a byte array from the
getFrameFromGifmethod, I'd return the stream and copy it to a filestream in order to remove the overhead of allocating and copying a new array for each time.