Generating maven projects in a subfolder

[khalilou88]

To isolate maven root project from nx root project and have better affected experience we are planning to generate all maven project in a sub folder.

For that we will use a mavenRootDirectory variable.

during init we need to to choose this variable

we will try to put it inside nx.json as a first option, or inside a .env file (in root folder)

EDIT:
https://nx.dev/recipes/tips-n-tricks/define-environment-variables

NX_maven_Root_Directory inside .env file

EDIT: final solution use nx-maven subefloder without use of a en var

[jbadeau]

Curious how tinesoft does it

tinesoft/nxrocks#179

[khalilou88]

@jbadeau I don't know about nx-spring-boot plugin and what i want to do is near what nx do with workspaceLayout.
Maybe we can try to find the first pom.xml to find mavenRootDirectory

[jbadeau]

if you can support multiple roots like:
Then I think it will be fine. I guess you could scan for all poms in root folders

[khalilou88]

That will make the plugin hard to use and understand. For me we should use one maven for all projects. And we should have one root pom.xml (or inside mavenRootDirectory) so every pom.xml can inherent from it.

[khalilou88]

another way to find mavenRootDirectory in my opinion is nx show projects withTag=nx-maven and choose the project based on projectRoot

Edit: Nx show don't have tag option so this option not possible

[khalilou88]

@jbadeau to make this feature simple I think about a fixed name for this subfolder. Let's say nx-maven.

If a root pom.xml is present, we use empty string for mavenRootDirectoty. If not we generate everything in nx-maven subfolder

For this, we just need to add a boolean to init generator

[jbadeau]

It u have a prerelease I’ll be happy to try it

[khalilou88]

@jbadeau I am working on implementing it

[jbadeau]

Cool, Much appreciated, just trying to avoid rework for you.

…

On Tue, 17 Oct 2023 at 19:04, khalilou88 ***@***.***> wrote: @jbadeau <https://github.com/jbadeau> I am working on implementing it — Reply to this email directly, view it on GitHub <#519 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFJOYGNYILKNVPVOTVX23X723BZAVCNFSM6AAAAAA6AFVR52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWHAZDKOBWGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jbadeau]

Cool, just trying to avoid rework for you.

[jbadeau]

nrwl/nx#19589

looks like a standard way to add options to plugins

[khalilou88]

@jbadeau seems what we are looking for (if I understand well)
But I am happy with the nx-maven as a subfolder. Finishing the tests and will publish a new version

[jbadeau]

Ok, do u publish as prerelease or are u sure it’s fine?

…

On Wed, 18 Oct 2023 at 14:47, khalilou88 ***@***.***> wrote: @jbadeau <https://github.com/jbadeau> seems what we are looking for (if I understand well) But I am happy with the nx-maven as a subfolder. Finishing the tests and will publish a new version — Reply to this email directly, view it on GitHub <#519 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFJO5BXK4F6VZRSYKBILTX77FVPAVCNFSM6AAAAAA6AFVR52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGM3TSOJZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[khalilou88]

prerelease don't work good for me, so i will publish a new version.
This feature is not the default option so I don't think will create a problem (tests are working fine).
Also it's a good feature so it's will not change in the future except maybe giving the possibility to change the folder name.

[khalilou88]

I published version 0.12.0 with this feature. Please use useSubfolder option : nx generate @jnxplus/nx-maven:init --parentProjectName ${parentProjectName} --useSubfolder

[jbadeau]

works! :)

Any change we can customize the subfolder name? I could make a pr.

[khalilou88]

For now it's not possible, but if you can find the rootproject based on a tag or variable, we can update this function:

export function getMavenRootDirectory() {
  const pomXmlPath = path.join(workspaceRoot, 'pom.xml');
  if (fs.existsSync(pomXmlPath)) {
    return '';
  }
  return 'nx-maven';
}

EDIT: MavenRootDirectory will be a variable inside nx.json

[khalilou88]

closing this issue. next changes will be here #535

[khalilou88]

This option is changed in version 0.13.0 to be mavenRootDirectory