Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for the files expiration rule #1

Closed
khalyomede opened this issue Jan 25, 2020 · 1 comment
Closed

Add a check for the files expiration rule #1

khalyomede opened this issue Jan 25, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@khalyomede
Copy link
Owner

Description

The generated files expirations rules are missing to check if the expire modules is ready to be used.

Reproduce the issue

Use the option fileExpirations and check on an Apache served website that the page displays an Apache error.

module.exports = {
  siteName: "Gridsome",
  plugins: [
    {
      use: "gridsome-plugin-htaccess",
      options: {
        fileExpirations: {
          fileTypes: {
            "image/jpeg": "access plus 1 week",
            "text/html": "access plus 1 hour",
            "application/javascript": "access plus 1 hour",
            "text/css": "access plus 1 hour"
          }
        },
      }
    }
  ]
}

Expected result

The rules should be wrapped by the <IfModule mod_expires.c> directive.

@khalyomede khalyomede self-assigned this Jan 25, 2020
@khalyomede khalyomede added the bug Something isn't working label Jan 25, 2020
@khalyomede
Copy link
Owner Author

Fixed via 1e023c6. Upgrade to the version 0.2.1 to get the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant