Code rule (apache#3016)

khanimteyaz · Jan 18, 2019 · 8ce6970 · 8ce6970
1 parent 1e31df6
commit 8ce6970
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/ClassUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/ClassUtils.java
@@ -79,7 +79,7 @@ public static Class<?> forName(String className) {
     }
 
     public static Class<?> _forName(String className) throws ClassNotFoundException {
-        switch(className){
+        switch (className) {
             case "boolean":
                 return boolean.class;
             case "byte":
@@ -112,6 +112,7 @@ public static Class<?> _forName(String className) throws ClassNotFoundException
                 return float[].class;
             case "double[]":
                 return double[].class;
+            default:
         }
         try {
             return arrayForName(className);

diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/json/JSON.java b/dubbo-common/src/main/java/org/apache/dubbo/common/json/JSON.java
@@ -579,6 +579,7 @@ private static Object parse(Reader reader, JSONVisitor handler, int expect) thro
                                         handler.objectItemValue(value, false);
                                         break;
                                     }
+                                    default:
                                 }
                             }
                             break;
@@ -629,6 +630,7 @@ private static Object parse(Reader reader, JSONVisitor handler, int expect) thro
                                         handler.objectItemValue(value, false);
                                         break;
                                     }
+                                    default:
                                 }
                             }
                             break;

diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/json/JSONWriter.java b/dubbo-common/src/main/java/org/apache/dubbo/common/json/JSONWriter.java
@@ -275,6 +275,7 @@ private void beforeValue() throws IOException {
             case OBJECT_VALUE:
                 mState.type = OBJECT;
                 return;
+            default:
         }
     }
 

diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/json/Yylex.java b/dubbo-common/src/main/java/org/apache/dubbo/common/json/Yylex.java
@@ -837,6 +837,7 @@ public JSONToken yylex() throws java.io.IOException, ParseException {
                         return null;
                     } else {
                         zzScanError(ZZ_NO_MATCH);
+                        break;
                     }
             }
         }

diff --git a/...-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftCodec.java b/...-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftCodec.java
@@ -66,11 +66,12 @@
  * <p>
  * <b>header fields in version 1</b>
  * <ol>
- *     <li>string - service name</li>
- *     <li>long   - dubbo request id</li>
+ * <li>string - service name</li>
+ * <li>long   - dubbo request id</li>
  * </ol>
  * </p>
  */
+
 /**
  * @since 2.7.0, use https://github.com/dubbo/dubbo-rpc-native-thrift instead
  */
@@ -108,7 +109,7 @@ public void encode(Channel channel, ChannelBuffer buffer, Object message)
         } else if (message instanceof Response) {
             encodeResponse(channel, buffer, (Response) message);
         } else {
-            throw new UnsupportedOperationException("Thrift codec only support encode " 
+            throw new UnsupportedOperationException("Thrift codec only support encode "
                     + Request.class.getName() + " and " + Response.class.getName());
         }
 
@@ -299,7 +300,7 @@ private Object decode(TProtocol protocol)
                     .getExtension(ThriftClassNameGenerator.NAME).generateResultClassName(serviceName, message.name);
 
             if (StringUtils.isEmpty(resultClassName)) {
-                throw new IllegalArgumentException("Could not infer service result class name from service name " 
+                throw new IllegalArgumentException("Could not infer service result class name from service name "
                         + serviceName + ", the service name you specified may not generated by thrift idl compiler");
             }
 
@@ -401,7 +402,7 @@ private void encodeRequest(Channel channel, ChannelBuffer buffer, Request reques
         String serviceName = inv.getAttachment(Constants.INTERFACE_KEY);
 
         if (StringUtils.isEmpty(serviceName)) {
-            throw new IllegalArgumentException("Could not find service name in attachment with key " 
+            throw new IllegalArgumentException("Could not find service name in attachment with key "
                     + Constants.INTERFACE_KEY);
         }
 
@@ -667,6 +668,7 @@ private void encodeResponse(Channel channel, ChannelBuffer buffer, Response resp
                 case TMessageType.REPLY:
                     resultObj.write(protocol);
                     break;
+                default:
             }
             protocol.writeMessageEnd();
             protocol.getTransport().flush();