-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Firefox Workflow Action #277
Conversation
Should let approval notes, license and release notes paramaters to be submitted
[chore/fix] bump firefox-addon version
this should be merged into #267 before it goes to main |
|
that's weird. looking into it but no idea what the issue there might be |
67420b0
to
0a4db4b
Compare
@cooljeanius ok that should fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field types and names match the action documentation
0a4db4b
to
52659d2
Compare
you should be good to cut a new release once 0.4.2 is merged, now. I think |
OK, so that fixed the previous parsing error; now there are some new ones from
(if we don't really care about these, it should be ok to just ignore them, I just think it's worthwhile to be explicit about being intentional about ignoring them) |
ok tbh yeah that's not a bad idea |
I just pushed it directly to the llb |
switches from publish-firefox-add-on to release-firefox-addon which should support all of the different inputs we need.
Modified the release to support the new version (along with downloading the release source code from github using cURL (god I hope that github actions has curl installed by default))
whoever approves this PLEASE check all of the input types I use against those defined in the action: https://github.com/marketplace/actions/release-firefox-addon#inputs