Fix twitter x rename #282
Merged
Fix twitter x rename #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheina
requested review from
jaredcat,
MrAwesome,
cooljeanius and
rougetimelord
as code owners
|
@rougetimelord compare against #281 |
|
Whoops totally missed those regexes in shared.ts! Still waiting to see if the API endpoints have changed over to the x.com domain from the reporter of #280, probably not a bad idea to just go ahead and add x.com to the regex for API endpoints but I kind of doubt that even Elon would break so many API wrappers like that. |
rougetimelord
approved these changes
May 16, 2024
kheina
added a commit
that referenced
this pull request
May 22, 2024
* Bump version string Need some diff to start an LLB PR * [fix] change condition for checking legacy if user used blue I did an oopsie whoopsie and flipped the logic in my brain!! * [doc] add all properties to the BlueBlockUser interface With the new integrations system I want to document everything that gets sent over so other extension devs can implement their own checks that use data that we don't. * [fix] refix skipping TweetTombstones Idk what happened here? Did I write code past my bed time? Maybe, no one can ever truly know * [fix] remove reference to chrome.runtime.restartAfterDelay * [chore] run prettier on src/background/index.ts * [feat] add endpoint for external extensions to automatically register as an integration External extensions can now send a request to Blue Blocker to be registered as a new integration. New integrations registered in this way are set to the disabled state by default, and the user of Blue Block still has to manually set the permissions of the new integration in order for the integration functionality to be enabled. This feature just makes it so that extension users do not have to find the extension ID of an external extension to register an integration. * Add the ability to block users based on their offensive usernames explain 'i' Reapply "case insensitive" This reverts commit ae0aa51. Revert "case insensitive" This reverts commit 2272caa. case insensitive Update index.ts Update index.html Update shared.ts Stylizing changes, refactor element name, add status element [Fix[ Unclosed textarea tag that caused safelist and integrations buttons to not render Add a warning to the option explanation Change to a better console log string Use input number rules for textarea Should make the textarea look more cohesive with the rest of the UI [Fix] Typo Refactor disallowed words update func, remove uneeded error logging, strip whitespace before storing Update shared.ts remove unused function * switch firefox workflow to new action * quote zip url and source filename * simple check * Fixes severe false positives * Add space/end lookahead to the end of generated regex The array.join method does not add the separator to the end of the last array entry, but we need the lookahead on each entry to make sure we don't match on fragments inside of a word * adds the option to skip blue checkmark users * [fix] add registerAction definition Co-authored-by: dani <29378233+kheina@users.noreply.github.com> * [fix] use registerAction instead of bare string Co-authored-by: dani <29378233+kheina@users.noreply.github.com> * [fix] Simplify regex for disallowed words Thx Dani for saving me from being lost in the sauce <3 * Fix twitter x rename (#282) Closes #280 Co-authored-by: dani <29378233+DanielleMiu@users.noreply.github.com> * [fix] don't spread browser.runtime * [fix] replace consecutive spaces with a single space, not delete them * [fix] simplify skipBlueCheckmark check * [fix] trim whitespace first Co-authored-by: dani <29378233+kheina@users.noreply.github.com> * [fix] use new api url for tweetdeck requests * [fix] use chrome.runtime type definition annoying annoying annoying :( * [fix] escape regex characters * [fix] move RegExp escaping to utilities, don't escape the word list that sits at rest this will all make sense in a bit lol * [fix] precompile disallowed word regex, treat emojis differently, store both list and regexp * [fix] i forgor how escapes in strings work 💀 * compile config * [fix] Use better emoji regex * [fix] remove .list from config key selection lol oops * [fix] use null to signal an empty word list * [chore] run prettier * cleanup block for use and verified logic a lot, add feature use reason * added other reason codes * cleanup popup immensely * add some more logging and some fixes to the page functions * move ts-ignore * add block disallowed words option * prettier hell * move use blue features block outside verified block so it still catches people when skip blue is enabled * move block for use outside verified func * more accurate wording --------- Co-authored-by: MaxIsJoe <34368774+MaxIsJoe@users.noreply.github.com> Co-authored-by: dani <29378233+kheina@users.noreply.github.com> Co-authored-by: Eric Gallager <egall@gwmail.gwu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should also take a serious look at these codeblocks, of which there are two in shared.ts
Blue-Blocker/src/shared.ts
Lines 80 to 84 in b4376ea
Blue-Blocker/src/shared.ts
Lines 80 to 84 in b4376ea
anything that references their domain name may have been updated including their api endpoints
Closes #280