Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rethrow methods to ProblemDetailsOptions #88

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add Rethrow methods to ProblemDetailsOptions #88

merged 1 commit into from
Feb 19, 2020

Conversation

bopazyn
Copy link
Contributor

@bopazyn bopazyn commented Feb 18, 2020

New methods are introduced. Previous method could be easily remove because no Nuget package was published with that changes.

@bopazyn bopazyn mentioned this pull request Feb 18, 2020
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
Copy link
Owner

@khellang khellang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just a tiny nit. I can clean it up if you don't want to 😊

src/ProblemDetails/ProblemDetailsOptions.cs Outdated Show resolved Hide resolved
@khellang khellang merged commit 2542eff into khellang:master Feb 19, 2020
@khellang
Copy link
Owner

Amazing. Thank yo so much for an awesome PR! ❤️

@khellang
Copy link
Owner

I'll try to get a new version out this week 😄

@bopazyn bopazyn deleted the feat-rethrow-exception branch February 20, 2020 00:21
@khellang
Copy link
Owner

Pushed v4.2.0 to NuGet 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants