Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Extensions.DependencyModel to version 3.1.6 on .NET Standard 2.0 #163

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

KuraiAndras
Copy link
Contributor

No description provided.

@khellang
Copy link
Owner

Hi @KuraiAndras! 👋

Thanks for the PR! Can we just bump it to 3.1.6? 🤔

Both .NET Core 2.1 and 3.0 are out of support by now, while 3.1 (oldest LTS) is still supported for a few more months. I'm assuming newer packages also support .NET Standard?

@KuraiAndras
Copy link
Contributor Author

Yes, they do. I just wanted it to be updated to the lowest possible version.

@KuraiAndras
Copy link
Contributor Author

Also, I think all other targets can be updated to the 6.0.0 version, since it supports both .net standard 2.0 and .NET Framework 4.6.1 https://www.nuget.org/packages/Microsoft.Extensions.DependencyModel/6.0.0

@KuraiAndras KuraiAndras changed the title Update Microsoft.Extensions.DependencyModel to version 3.0.0 Update Microsoft.Extensions.DependencyModel to version 3.1.6 on .NET Standard 2.0 Feb 11, 2022
@khellang
Copy link
Owner

In principle, I'd like to keep the required versions as low as possible for greater compatibility with older versions. But there's no point in keeping around unsupported versions if there are newer breaking/incompatible changes or better APIs in newer versions 😅

I'd be comfortable bumping everything to 3.1 (same as the netcoreapp3.1 target) though.

@KuraiAndras
Copy link
Contributor Author

@khellang I have updated the version on the net461 target too.

@khellang khellang merged commit 3b44333 into khellang:master Feb 14, 2022
@khellang
Copy link
Owner

Thanks for this @KuraiAndras! 🙏🏻 I'll try to get a new version out ASAP 😄

@KuraiAndras KuraiAndras deleted the update-dependencymodel-version branch February 14, 2022 13:07
@KuraiAndras
Copy link
Contributor Author

@khellang any update on the new release?

@khellang
Copy link
Owner

khellang commented Mar 2, 2022

Sorry it took so long @KuraiAndras! v4.1.0 has been pushed to NuGet now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants