Select behavior for RegistrationStrategy.Skip #167 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I added support for variable skip registration #167.
Skip can be configured to skip registration depending on the selected behavior.
SkipBehaviorhas 4 statesDefault,ServiceType,SkipBehaviorandExact, which useTryAdd(for default and service type), a tweaked version ofTryAddandTryAddEnumerablerespectively.Added some basic test in line with the other
RegistrationStrategymethods, each test checks the right number of services are registered and that the older descriptor is registered.I'm pretty sure this is a breaking change, the new
Skipmethod could be renamed toSkipByso code using the oldUsingRegistrationStrategy(RegistrationStrategy.Skip)would still be valid.Hopefully this is useful, Thanks!