Skip to content
This repository has been archived by the owner on Feb 1, 2020. It is now read-only.

Update composer to include pdo-log #1

Merged
1 commit merged into from
Nov 26, 2013
Merged

Update composer to include pdo-log #1

1 commit merged into from
Nov 26, 2013

Conversation

tomsowerby
Copy link
Contributor

Missing Herrero\Pdo\Pdo when using this without the pdo-log library.

Missing Herrero\Pdo\Pdo when using this without the pdo-log library.
@ghost
Copy link

ghost commented Nov 23, 2013

Hi @tomsowerby, could you please help me understand the reasoning behind this PR?

@tomsowerby
Copy link
Contributor Author

Hello,
I apologise, I wans't very clear.
src/lib/Herrera/Pdo/PdoServiceProvider.php line 6
https://github.com/herrera-io/php-silex-pdo/blob/master/src/lib/Herrera/Pdo/PdoServiceProvider.php#L6
has

use Herrera\Pdo\Pdo as PdoLog;

yet Herrera\Pdo\Pdo doesn't appear to be available within the library or it's current dependencies?

@ghost
Copy link

ghost commented Nov 25, 2013

Do you use the php-pdo-log package in production?

@tomsowerby
Copy link
Contributor Author

Ah I see, you're assuming that debug mode can never be used on production?
Or that dev and debug are mutually exclusive at least?

@ghost
Copy link

ghost commented Nov 26, 2013

I see your point!

ghost pushed a commit that referenced this pull request Nov 26, 2013
Update composer to include pdo-log
@ghost ghost merged commit 41b5f3d into kherge-archive:master Nov 26, 2013
@ghost
Copy link

ghost commented Nov 26, 2013

This patch has been released as 1.2.1.

@tomsowerby
Copy link
Contributor Author

Great, thanks.
A class exists check might be another way to go about this. The logging could be useful to users in production though.
Thanks for all of your work on Silex libraries. This is the first time that I've used it and I keep finding libraries of yours when solving problems.

@ghost
Copy link

ghost commented Nov 26, 2013

I'm glad they're useful!

@tomsowerby tomsowerby deleted the patch-1 branch November 27, 2013 08:50
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant