Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

output filename with replacement seems not working #75

Closed
llaville opened this issue Feb 18, 2014 · 7 comments
Closed

output filename with replacement seems not working #75

llaville opened this issue Feb 18, 2014 · 7 comments
Labels

Comments

@llaville
Copy link

For the last report today.

I've try to use the feature used by your file
https://github.com/kherge-old/Box/blob/2.0/box.json.dist#L35

But it seems not working for me. Can you confirm it's possible ?

Thanks in advance
Laurent

@llaville
Copy link
Author

I've used both syntax

"git-commit": "git_commit",
"git-version": "package_version",
"output": "phpreflect-@git-version@.phar",

and

"git-commit": "git_commit",
"git-version": "package_version",
"output": "phpreflect-@package_version@.phar",

But I always got file not renamed.

@ghost
Copy link

ghost commented Feb 18, 2014

Is the project you're working on available somewhere? If it's okay, I'd like to test it directly against your code. I know this works for Box, since I do get versioned output files.

@llaville
Copy link
Author

Yes, of course you can.
The project is on the branch v2 here https://github.com/llaville/php-reflect/tree/v2
with the box.json file (where I've removed "output" renaming option)

@ghost
Copy link

ghost commented Feb 20, 2014

Okay, I was able to repeat the problem, even in Box. I don't know what's changed but I'll try and fix it.

@ghost ghost added the Bug label Feb 20, 2014
@ghost
Copy link

ghost commented Feb 27, 2014

Note: This problem only happens with the phar version of Box, but not with the Composer installed version.

@ghost ghost self-assigned this Feb 27, 2014
@ghost ghost closed this as completed in 71938bf Feb 27, 2014
@ghost
Copy link

ghost commented Feb 27, 2014

Okay, it's fixed! Use Box 2.4.4.

@llaville
Copy link
Author

I confirm, it works fine. Thanks :)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant