Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "no suffix" generation in CMake even if MPI is available #250

Open
bruno-at-orange opened this issue May 6, 2024 · 3 comments
Open
Labels
Priority/2 To do after P1

Comments

@bruno-at-orange
Copy link
Contributor

In conda we do not need the MPI suffixes, and it would simplify the lookup for the executable. At the moment I just rename it after the build.

@bruno-at-orange
Copy link
Contributor Author

We can easily add a new option in the CMakeFiles.txt e.g. NO_MPI_SUFFIX. But it will introduce an inconsistency in cmake: if NO_MPI_SUFFIX=OFF, cpack will fail with DEB and RPM as it requires now mpi suffixes.
There is perhaps another way: why not use a symlink from MODL to MODL_suffix as it is done with DEB and RPM. Even better we could use cmake install command in conda.

@bruno-at-orange
Copy link
Contributor Author

Actually, the mpi suffix discovering process fails on conda (all mpi libs are located on the same directory, there is no information about the mpi implementation AFAIK). Then there is no suffix under conda environment. It is more a good side-effect than a feature.

@alexisbondu alexisbondu added the Priority/2 To do after P1 label May 15, 2024
@alexisbondu
Copy link
Collaborator

Regarder le lien avec Khiops Env pour une intégration propre dans pyKhiops => simplification possible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority/2 To do after P1
Projects
None yet
Development

No branches or pull requests

2 participants