Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITF class level annotations misbehave #359

Closed
cstamas opened this issue May 22, 2023 · 0 comments
Closed

ITF class level annotations misbehave #359

cstamas opened this issue May 22, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cstamas
Copy link

cstamas commented May 22, 2023

Describe the bug
ITF annotations applied at class level are applied only to first test method invocation, but not subsequent.

To Reproduce
Build https://github.com/openrewrite/rewrite-maven-plugin

Observe how ITs with one test method like this class:
https://github.com/openrewrite/rewrite-maven-plugin/blob/main/src/test/java/org/openrewrite/maven/BasicIT.java
are invoked.

Am actually unsure here, about the "class level" semantics, it is maybe me understanding it wrongly.

Current behavior
Only first test method have them applied, rest not,

Expected behavior
A class level ITF annotation should be applied to all test methods.

Also, see openrewrite/rewrite-maven-plugin#560 (comment)

@cstamas cstamas added the bug Something isn't working label May 22, 2023
@cstamas cstamas changed the title ITS class level annotations misbehave ITF class level annotations misbehave May 22, 2023
@khmarbaise khmarbaise self-assigned this Jun 9, 2023
@khmarbaise khmarbaise added this to the itf-extension-0.13.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants