Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #405 - Change the scope for deps #407

Merged
merged 1 commit into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
:issue-398: https://github.com/khmarbaise/maven-it-extension/issues/398[Fixed #398]
:issue-399: https://github.com/khmarbaise/maven-it-extension/issues/399[Fixed #399]
:issue-401: https://github.com/khmarbaise/maven-it-extension/issues/401[Fixed #401]
:issue-405: https://github.com/khmarbaise/maven-it-extension/issues/405[Fixed #405]
:issue-??: https://github.com/khmarbaise/maven-it-extension/issues/??[Fixed #??]

:release_0_13_0: https://github.com/khmarbaise/maven-it-extension/milestone/13
Expand Down Expand Up @@ -129,6 +130,7 @@
* {issue-398} - Make Build working with JDK21.
* {issue-401} - Upgrade Build Minimum to Maven 3.9.6
* {issue-331} - Build failure with Maven 4.0.0-alpha-4
* {issue-405} - Change the scope for deps


The full release notes can be found here {release_0_13_0}[Release 0.13.0].
14 changes: 9 additions & 5 deletions itf-failure-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,32 @@
<packaging>maven-plugin</packaging>
<artifactId>itf-failure-plugin</artifactId>

<properties>
<mavenMinimumVersion>3.2.5</mavenMinimumVersion>
</properties>
<dependencies>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>3.1.0</version>
<version>${mavenMinimumVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>3.1.0</version>
<version>${mavenMinimumVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenMinimumVersion}</version>
<scope>provided</scope>
<version>3.1.0</version>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>3.6.0</version>
<version>${maven-plugin-plugin.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -115,7 +120,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<version>3.6.0</version>
<executions>
<execution>
<id>default-descriptor</id>
Expand Down
17 changes: 8 additions & 9 deletions itf-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

<properties>
<mavenMinimumVersion>3.2.5</mavenMinimumVersion>
<maven.plugin.tool>3.6.4</maven.plugin.tool>
</properties>

<prerequisites>
Expand Down Expand Up @@ -72,6 +71,13 @@
<version>${mavenMinimumVersion}</version>
<scope>provided</scope>
</dependency>
<!-- Need to reconsider this -->
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-aether-provider</artifactId>
<version>${mavenMinimumVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
Expand All @@ -82,12 +88,6 @@
<artifactId>plexus-interpolation</artifactId>
<version>1.26</version>
</dependency>
<!-- Need to reconsider this -->
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-aether-provider</artifactId>
<version>${mavenMinimumVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-filtering</artifactId>
Expand All @@ -101,7 +101,7 @@
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>${maven.plugin.tool}</version>
<version>${maven-plugin-plugin.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -143,7 +143,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<version>${maven.plugin.tool}</version>
<executions>
<execution>
<id>default-descriptor</id>
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
-->
<trimStackTrace>false</trimStackTrace>
<automatic-module-name>com.soebes.itf.extension</automatic-module-name>
<maven-plugin-plugin.version>3.10.2</maven-plugin-plugin.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -165,7 +166,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<version>3.10.2</version>
<version>${maven-plugin-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
Expand Down