Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only push _versioned_ image to Docker Hub #24

Closed
khoa-io opened this issue May 22, 2022 · 0 comments · Fixed by #27
Closed

Only push _versioned_ image to Docker Hub #24

khoa-io opened this issue May 22, 2022 · 0 comments · Fixed by #27
Assignees
@khoa-io
Labels
enhancement New feature or request
Milestone
v0.0.2

Comments

@khoa-io
Copy link
Owner

khoa-io commented May 22, 2022

Currently, every push or pull request to main trigger CI. Therefore, a new image will be pushed to Docker Hub with the tag ${{ secrets.DOCKER_HUB_USERNAME }}/amz-git-mirroring:${{ env.BUILD_NUMBER }}-${{ env.SHORT_SHA }}. This will overpopulate the Docker Hub repository. Only versioned image should be pushed with the tag ${{ secrets.DOCKER_HUB_USERNAME }}/amz-git-mirroring:${{ env.BUILD_VERSION }}.
@khoa-io khoa-io added the enhancement New feature or request label May 22, 2022
@khoa-io khoa-io added this to the v0.0.2 milestone May 22, 2022
@khoa-io khoa-io self-assigned this May 22, 2022
khoa-io added a commit that referenced this issue May 22, 2022
@khoa-io
Only push _versioned_ image to Docker Hub
88d1dee 
Fixes #24
@khoa-io khoa-io mentioned this issue May 22, 2022
Merged
khoa-io added a commit that referenced this issue May 22, 2022
@khoa-io
Only push _versioned_ image to Docker Hub
156ad9f 
Fixes #24
khoa-io added a commit that referenced this issue May 22, 2022
@khoa-io
Improve CI and Release
1d24b95 
Fix #24
- Improve versioning
- Synchronize contents except BUILD_VERSION and push steps
- Build images for multiple architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khoa-io khoa-io

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.2
Development

Successfully merging a pull request may close this issue.

Only push _versioned_ image to Docker Hub khoa-io/git-lfs-server
1 participant
@khoa-io