Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile-navgiation): bottom menu for sudo admin and admin #392

Merged
merged 10 commits into from
Jun 29, 2024
Merged

feat(mobile-navgiation): bottom menu for sudo admin and admin #392

merged 10 commits into from
Jun 29, 2024

Conversation

Krr0ptioN
Copy link
Collaborator

Description

Bottom menu navigation instead of bottom up drawer

UI Changes

  • Page sizing is greatly improved
  • Bottom menu for mobile navigation (supports sudo-admin, admin)

Screenshots

Refactorings

  • Toggle Button
  • A new hook for current active route logic

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests (stories, interaction tests, unit tests, e2e tests) to cover my changes.
  • I have added tests to cover my changes.

Related Issues

Closes #287

@Krr0ptioN Krr0ptioN added feature New feature or request refactor Refactoring existing design and implementation improvement Improving and harnessing the quality criteria of an already existing feature and implementation frontend feat:sidebar labels Jun 24, 2024
@Krr0ptioN Krr0ptioN self-assigned this Jun 24, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marzneshin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 10:00pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

🔍 Visual review for your branch is published 🔍

Here are the links to:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Krr0ptioN Krr0ptioN merged commit 7bd6cce into master Jun 29, 2024
15 checks passed
@Krr0ptioN Krr0ptioN deleted the feat/mobile-navigation branch June 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khodedawsh khodedawsh Awaiting requested review from khodedawsh

Assignees

@Krr0ptioN Krr0ptioN

Labels
feat:sidebar feature New feature or request frontend improvement Improving and harnessing the quality criteria of an already existing feature and implementation refactor Refactoring existing design and implementation
Projects
Marzneshin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Bottom navigation sidebar instead of bottom up drawer
1 participant
@Krr0ptioN