This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
added setUDP function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function that allows setting the UDP socket after the declaration of the NTPClient element. This allows you to use Ethernet and WiFi within the same code and switch between them at run time.
|
Hi @argo9 I just have some time to look at your PR, which is very good feature to have. I'll merge, then publish a new release, along with some new examples to use the new enhancement for auto-switching between WiFi and Ethernet UDP to update NTP time. Thanks for your good idea and looking forward to receiving more PRs from you. Regards, |
khoih-prog
added a commit
that referenced
this pull request
Feb 24, 2022
### Releases v3.7.2 1. Add setUDP() function to enable auto-switching between `WiFi` and `Ethernet` UDP instances. Check [added setUDP function #8](#8) 2. Add new examples [ESP_WiFi_ETH_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/ESP/ESP_WiFi_ETH_NTPClient_Advanced) and [WT32_WiFi_ETH01_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/WT32_ETH01/WT32_WiFi_ETH01_NTPClient_Advanced) to use the new setUDP() function for auto-switching between `WiFi` and `Ethernet` UDP to update NTP time. 3. Update `Packages_Patches`
khoih-prog
added a commit
that referenced
this pull request
Feb 24, 2022
### Releases v3.7.2 1. Add setUDP() function to enable auto-switching between `WiFi` and `Ethernet` UDP instances. Check [added setUDP function #8](#8) 2. Add new examples [ESP_WiFi_ETH_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/ESP/ESP_WiFi_ETH_NTPClient_Advanced) and [WT32_WiFi_ETH01_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/WT32_ETH01/WT32_WiFi_ETH01_NTPClient_Advanced) to use the new setUDP() function for auto-switching between `WiFi` and `Ethernet` UDP to update NTP time. 3. Update `Packages_Patches`
khoih-prog
added a commit
that referenced
this pull request
Feb 24, 2022
### Releases v3.7.2 1. Add setUDP() function to enable auto-switching between `WiFi` and `Ethernet` UDP instances. Check [added setUDP function #8](#8) 2. Add new examples [ESP_WiFi_ETH_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/ESP/ESP_WiFi_ETH_NTPClient_Advanced) and [WT32_WiFi_ETH01_NTPClient_Advanced](https://github.com/khoih-prog/NTPClient_Generic/tree/main/examples/WT32_ETH01/WT32_WiFi_ETH01_NTPClient_Advanced) to use the new setUDP() function for auto-switching between `WiFi` and `Ethernet` UDP to update NTP time. 3. Update `Packages_Patches`
|
Hi @argo9 The new NTPClient_Generic releases v3.7.2 has just been published. Your contribution is noted in Contributions and Thanks Please check the new examples as well as the debug terminal output when running example ESP_WiFi_ETH_NTPClient_Advanced Best Regards, Releases v3.7.2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function that allows setting the UDP socket after the declaration of the NTPClient element.
This allows you to use Ethernet and WiFi within the same code and switch between them at run time.