Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

float precisison of DutyCycle only sometimes working #3

Closed
toniMephis opened this issue Mar 3, 2022 · 2 comments
Closed

float precisison of DutyCycle only sometimes working #3

toniMephis opened this issue Mar 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@toniMephis
Copy link

Arduino IDE version: 1.8.19 (Windows 1.8.57.0)
Arduino SAMD Core Version 1.8.12
ARDUINO_SAMD_MKRWIFI1010
OS: Windows10
sketch: example ISR_Modify_PWM
screenshot attached
Clipboard02
d
@khoih-prog
Copy link
Owner

Hi @toniMephis

Thanks again for this bug report.

Please change these 2 lines

SAMD_Slow_PWM/examples/SAMD21/ISR_Modify_PWM/ISR_Modify_PWM.ino

Lines 147 to 148 in b0229b7

double PWM_Freq;
uint32_t PWM_DutyCycle;

from

double PWM_Freq;
uint32_t PWM_DutyCycle;

to

float PWM_Freq;
float PWM_DutyCycle;

I forgot to change after modifying dutycycle from uint32_t to float

Will update in the master as well as in new release.

@khoih-prog khoih-prog mentioned this issue Mar 3, 2022
Closed
khoih-prog added a commit that referenced this issue Mar 3, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug
497d6c9 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](#3)
2. Fix `New Period` display bug. Check [random dropouts #4](#4)
3. Update examples
@khoih-prog
Copy link
Owner

Hi @toniMephis

The new SAMD_Slow_PWM releases v1.2.3 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,

PS:

I wish to have every user as investigative and thorough as you to test and reveal so many bugs of this library.
I'm just afraid that there will be less and less of bugs for us to deal with in the future ;={}

Releases v1.2.3

  1. Fix DutyCycle bug. Check float precisison of DutyCycle only sometimes working #3
  2. Fix New Period display bug. Check random dropouts #4
  3. Update examples

@khoih-prog khoih-prog added the bug Something isn't working label Mar 3, 2022
khoih-prog added a commit to khoih-prog/nRF52_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
7b69f80 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Display informational warning only when `_PWM_LOGLEVEL_` > 3
4. Add support to `Sparkfun Pro nRF52840 Mini`
5. Update examples
6. Update `Packages' Patches`
khoih-prog added a commit to khoih-prog/nRF52_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
ac7f45e 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Display informational warning only when `_PWM_LOGLEVEL_` > 3
4. Add support to `Sparkfun Pro nRF52840 Mini`
5. Update examples
6. Update `Packages' Patches`
khoih-prog added a commit to khoih-prog/nRF52_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
31c4bdf 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Display informational warning only when `_PWM_LOGLEVEL_` > 3
4. Add support to `Sparkfun Pro nRF52840 Mini`
5. Update examples
6. Update `Packages' Patches`
khoih-prog added a commit to khoih-prog/nRF52_MBED_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
36036c9 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/nRF52_MBED_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
d5e83b0 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/RP2040_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug
1c17084 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/RP2040_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug
2e01bf2 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/AVR_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
e52cd46 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/AVR_Slow_PWM that referenced this issue Mar 4, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
355eabc 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/megaAVR_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
d719f9f 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/megaAVR_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
5150e56 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/megaAVR_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
ad9e20c 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/STM32_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
4e4a7fe 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/STM32_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
17eed70 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/STM32_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
5ff2144 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/STM32_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.3 to fix DutyCycle bug, etc.
a8c66bd 
### Releases v1.2.3

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/Portenta_H7_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
d2f1000 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
4. Update `Packages' Patches`
khoih-prog added a commit to khoih-prog/Portenta_H7_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
64cbccf 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
4. Update `Packages' Patches`
khoih-prog added a commit to khoih-prog/SAMDUE_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.2 to fix DutyCycle bug, etc.
4e96842 
### Releases v1.2.2

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/SAMDUE_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.2 to fix DutyCycle bug, etc.
147a567 
### Releases v1.2.2

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/SAMDUE_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.2 to fix DutyCycle bug, etc.
2201f34 
### Releases v1.2.2

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/Teensy_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
cdd23d2 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/Teensy_Slow_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.1 to fix DutyCycle bug, etc.
f228fe9 
### Releases v1.2.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/ESP8266_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.4 to fix DutyCycle bug, etc.
192da87 
### Releases v1.2.4

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/ESP8266_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.2.4 to fix DutyCycle bug, etc.
878e12f 
### Releases v1.2.4

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/ESP32_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.3.1 to fix DutyCycle bug, etc.
8ec2d60 
### Releases v1.3.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
khoih-prog added a commit to khoih-prog/ESP32_PWM that referenced this issue Mar 5, 2022
@khoih-prog
v1.3.1 to fix DutyCycle bug, etc.
aa86755 
### Releases v1.3.1

1. Fix `DutyCycle` bug. Check [float precisison of DutyCycle only sometimes working #3](khoih-prog/SAMD_Slow_PWM#3)
2. Fix `New Period` display bug. Check [random dropouts #4](khoih-prog/SAMD_Slow_PWM#4)
3. Update examples
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khoih-prog @toniMephis