Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-User]: Part 0 - Add support for logging in with Google #487

Merged
merged 26 commits into from
Oct 15, 2023

Conversation

sabaimran
Copy link
Collaborator

@sabaimran sabaimran commented Sep 30, 2023

Incoming

  • Integrate the Django ORM for interacting with the db and managing tables
  • Allows users to login / sign up with their Google account
  • This currently has no impact whatsoever on functionality, it just introduces the baseline support so we can later partition settings by user in the DB and later support pg_vector for embeddings storage

Begins implementation for #487. As a follow-up to this, the next step will be to integrate this into the actual application and partition user settings and data storage by user.

@sabaimran sabaimran added the upgrade New feature or request label Sep 30, 2023
@khoj-ai khoj-ai deleted a comment from gitguardian bot Oct 14, 2023
src/app/asgi.py Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
src/app/asgi.py Outdated Show resolved Hide resolved
src/database/tests.py Outdated Show resolved Hide resolved
src/khoj/configure.py Show resolved Hide resolved
src/khoj/configure.py Outdated Show resolved Hide resolved
src/khoj/routers/api.py Outdated Show resolved Hide resolved
src/khoj/routers/api.py Outdated Show resolved Hide resolved
src/khoj/routers/api.py Outdated Show resolved Hide resolved
src/app/asgi.py Outdated Show resolved Hide resolved
@gitguardian
Copy link

gitguardian bot commented Oct 15, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8175313 Django Secret Key 869c37f src/app/settings.py View secret
8175313 Django Secret Key 6fa925e src/app/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sabaimran sabaimran merged commit c125995 into features/multi-user-support-khoj Oct 15, 2023
1 check failed
@sabaimran sabaimran deleted the features/multi-user branch October 15, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants