Fix process for generating embeddings for Notion entries #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debanjum
approved these changes
Feb 20, 2024
Comment on lines
+115
to
+117
| current_entries = TextToEntries.split_entries_by_max_tokens(current_entries, max_tokens=256) | ||
|
|
||
| return self.update_entries_with_ids(current_entries, user=user) |
There was a problem hiding this comment.
Oh, was the issue just that we weren't splitting the entries by max token? Why was that breaking indexing of Notion entries?
There was a problem hiding this comment.
Ah, that method also generally handles logic for splitting up the data into chunks and creating the Entry items that make it easy to write to the db.
|
Closes #637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't previously generating the embeddings correctly for the Notion entries. Update to resolve the embeddings logic.
Resolves #637