Commits on Mar 9, 2024

1. Do not create new chat session when an old chat session is deleted …

   - Fix
     `get_conversation_by_user' shouldn't return new conversation if
     conversation with requested id not found.
   
     It should only return new conversation if no specific conversation
     is requested and no conversations found for user at all
   
   - Repro
     - Delete a new chat, this calls loadChat via window.onload which
       calls server /chat/history API endpoint with conversationId set to
       that of just deleted conversation sporadically
   
       The call to GET chat/history API with conversationId set occurs
       when window.onload triggers before the conversationId is deleted
       by the delete button after the DELETE /chat/history API call (via race)
   
     - In such a scenario, get_conversation_by_user called by
       chat/history API with conversationId of deleted conversation
       returns a new conversation
   
   - Miscellaneous
     - Chat history load should be logged as call to that chat_history api,
       not the "chat" api
     - Show status updates of clearing conversation history in chat input
     - Simplify web, desktop client code by removing unnecessary new variables

   

   debanjum committed Mar 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for fd81446
   • Browse repository at this point

   Copy the full SHA

   fd81446 View commit details

   Browse the repository at this point in the history