Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conversations optionally shareable #712

Merged
merged 14 commits into from
May 5, 2024

Conversation

sabaimran
Copy link
Collaborator

@sabaimran sabaimran commented Apr 19, 2024

Incoming

  • Shared conversations are viewable by anyone, without a login wall
  • Can share a conversation from the three dot menu
  • Add a new model for Public Conversation
  • The rationale for a separate model is that public and private conversations have different assumptions. Separating them reduces some of the code specificity on our server-side code and allows us for easier interpretation and stricter security. Separating the data model makes it harder to accidentally view something that was meant to be private
  • Add a new, read-only view for public conversations. It has a list of available agents on the side panel.

- Shared conversations are viewable by anyone, without a login wall
- Can share a conversation from the three dot menu
- Add a new model for Public Conversation
- The rationel for a separate model is that public and private conversations have different assumptions. Separating them reduces some of the code specifity on our server-side code and allows us for easier interpretation and stricter security. Separting the data model makes it harder to accidentally view something that was meant to be private
- Add a new, read-only view for public conversations
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It'll simplify sharing responses by Khoj with others instead of the previous clunky copy/paste each message + mention it was generated by Khoj mechanism

src/khoj/database/models/__init__.py Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/web_client.py Outdated Show resolved Hide resolved
src/khoj/routers/web_client.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Show resolved Hide resolved
@sabaimran sabaimran merged commit 14c9bea into master May 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants