Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Adding File Filtering to Conversations #788

Merged

Conversation

MythicalCow
Copy link
Contributor

  • Interactive file menu #UI to add/remove files on each conversation as references.
  • Backend changes implemented to load selected file filters from a conversation into the querying process.

Screenshot 2024-05-30 174005
Screenshot 2024-05-30 173917

@MythicalCow MythicalCow added the upgrade New feature or request label May 31, 2024
@MythicalCow MythicalCow self-assigned this May 31, 2024
Copy link
Collaborator

@sabaimran sabaimran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good initial set of changes.

src/khoj/database/models/__init__.py Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/routers/api.py Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/routers/api_chat.py Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/routers/api.py Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Jun 3, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10005301 Triggered Generic Password 0c129ca src/khoj/app/settings.py View secret
10005301 Triggered Generic Password 649edd0 src/khoj/app/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, otherwise code looks neat!

src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
src/khoj/interface/web/chat.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@sabaimran sabaimran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! This is a super critical improvement 🚀

@sabaimran sabaimran merged commit ba16afd into khoj-ai:master Jun 7, 2024
6 of 7 checks passed
sabaimran pushed a commit that referenced this pull request Jun 18, 2024
* Uses entire file text and summarizer model to generate document summary.
* Uses the contents of the user's query to create a tailored summary.
* Integrates with File Filters #788 for a better UX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants