Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create App Directory, Fix Initialization GUI on First Run #81

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Sep 9, 2022

  • 588f598 Pass empty list of input_files to FileBrowser on first run
  • 3ddffdf Create config directory before setting up logging to file under it

Resolves #78
Resolves #79
Resolves #80

- The logging to file code expects the config directory to already be setup
- But parent directory of config file was being set up later in code
- This resulted in app start failing with ~/.khoj dir does not exist error
- Default config has `input_files' set to None
- This was being passed to `FileBrowser' on Initialization
- But `FileBrowser' expects `content_files' of list type, not None
- This resulted in an unexpected NoneType failure
@debanjum debanjum changed the title Fix App Initialization on First Run Create App Directory, Fix Initialization GUI on First Run Sep 9, 2022
This was linked to issues Sep 9, 2022
This was unlinked from issues Sep 9, 2022
@debanjum debanjum merged commit b58b7d7 into master Sep 9, 2022
@debanjum debanjum deleted the fix-app-init-on-first-run branch September 9, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing on Manjaro khoj-assistant errors on Arch Linux Error on startup
1 participant