Add developer support for using next.js to serve generated static files #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…katext.js working with loaded chat history
…erent github actions workflows to run in CI with the new assets
sabaimran
commented
Jun 12, 2024
sabaimran
commented
Jun 12, 2024
sabaimran
commented
Jun 12, 2024
| - prod.Dockerfile | ||
| - docker-compose.yml | ||
| - .github/workflows/dockerize.yml | ||
| pull_request: |
There was a problem hiding this comment.
Remove this and make PR builds optional?
MythicalCow
suggested changes
Jun 18, 2024
debanjum
approved these changes
Jun 19, 2024
|
|
||
| export const metadata: Metadata = { | ||
| title: "Khoj AI", | ||
| description: "Your, open-source, personal AI assistant", |
There was a problem hiding this comment.
Suggested change
| description: "Your, open-source, personal AI assistant", | |
| description: "Your open, personal AI", |
or to match the description on the other clients (desktop, emacs, obsidian)
Suggested change
| description: "Your, open-source, personal AI assistant", | |
| description: "An AI copilot for your Second Brain", |
There was a problem hiding this comment.
The favicon isn't seeming to be loaded, used by the next.js web app?
Comment on lines
+34
to
+41
| { | ||
| protocol: "https", | ||
| hostname: "khoj-web-bucket.s3.amazonaws.com", | ||
| }, | ||
| { | ||
| protocol: "https", | ||
| hostname: "khoj-generated-images.s3.amazonaws.com", | ||
| } |
There was a problem hiding this comment.
These two s3 buckets shouldn't be required anymore? Those buckets are deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the developer experience for front-end development, we're migrating to Next.js. In order to do this migration page-by-page, we're using static site generation via Next.js. This also helps us avoid making cross site requests from front-end to back-end for the time being, while giving a ramp to separating out server and client if needed for scale down the road.
Dev instructions for using the
next.jssetup are in the added README.This adds scaffolding for including the built files in the python package as well as the docker images. Docker setup has been tested locally. In order to verify the build is working as expected, we can navigate to the
{khoj_host}:42110/experimentaland verify that the experiment page comes up.This setup works with serving static files included in the
src/interface/webfolder from the Django app. The key bit for understanding the setup is in theyarn exportcommand inpackage.json.