Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial server implementation #28

Merged
merged 27 commits into from
Apr 14, 2021
Merged

Initial server implementation #28

merged 27 commits into from
Apr 14, 2021

Conversation

ecton
Copy link
Member

@ecton ecton commented Apr 4, 2021

Closes #19

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #28 (40eb7a1) into main (1d97b0d) will decrease coverage by 6.90%.
The diff coverage is 80.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   70.99%   64.08%   -6.91%     
==========================================
  Files          28       51      +23     
  Lines        3575     6296    +2721     
==========================================
+ Hits         2538     4035    +1497     
- Misses       1037     2261    +1224     
Impacted Files Coverage Δ
jobs/src/lib.rs 100.00% <ø> (ø)
jobs/src/traits.rs 0.00% <ø> (ø)
local/src/error.rs 93.33% <ø> (+83.88%) ⬆️
local/src/lib.rs 100.00% <ø> (ø)
server/src/cli/certificate.rs 0.00% <0.00%> (ø)
server/src/cli/mod.rs 0.00% <0.00%> (ø)
server/src/cli/serve.rs 0.00% <0.00%> (ø)
client/src/error.rs 6.25% <6.25%> (ø)
local/src/tasks.rs 95.14% <25.00%> (+0.09%) ⬆️
local/src/config.rs 86.66% <33.33%> (+25.17%) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d97b0d...40eb7a1. Read the comment docs.

ecton added 10 commits April 5, 2021 21:04
Very rough but having troubles with the networking crate.
Introduced ServerConnection trait which acts as the analog to the
Connection trait in core.
Similar to how the Connection tests are shared, the ServerConnection
tests are executed both locally and over the Client (although the Client
tests are still disabled right now).
Some sort of race condition in list_transactions when using futures to
spam the insert. Lots of documentation and cleanup to go.
@ecton
Copy link
Member Author

ecton commented Apr 9, 2021

This is now "feature complete". Need to:

  • write docs for the networking types
  • Figure out whether I care about making the type-less APIs on Storage accessible only through a trait that marks them as internal only. Because the APIs cross crate boundaries, I can't make them truly private APIs. Users really shouldn't use much outside fo the Connection and ServerConnection traits.

@ecton
Copy link
Member Author

ecton commented Apr 13, 2021

Things left as of this morning's review process:

  • Add server configuration
  • Write server example
  • Write server documentation:
    • trusted-dns
    • websockets
  • Add integration-style test with multiple clients.

Converted existing "example" to an integration-style test. Also added
ability to reduce_grouped, closes #22.
Also renamed certificate to certificate-generation
@ecton ecton marked this pull request as ready for review April 14, 2021 00:19
@ecton ecton merged commit fe2fed8 into main Apr 14, 2021
@ecton ecton deleted the server branch April 14, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Begin implementing a Server
1 participant