Add WebAssembly Client #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a WebAssembly-compatible version of the client that supports WebSockets. Some error handling code needs to be handled. Currently, the client will not reconnect after failing. Additionally, if all clients are dropped, the connection does not disconnect. Other than that, it should be fully functional. Need to investigate unit testing and how to best launch a native server while testing in wasm.
This makes dropping safe regardless of if it was in a non-tokio context.
When building without websocket support, tokio is still used for it JoinHandle.
I originally thought that I should try using select here, but after more thought, it would just make this code harder to understand. The comment may have predated a refactor -- my aversion to using try_join was only when I was mapping a success to error failure to abort try_join early. Select should be more clear in that situation. That doesn't describe this location, however.
Originally I thought it made more sense to do things differently in wasm, but it really didn't. Now connections aren't attempted until the first request arrives, and whichever request causes the connection error will get it returned to them. This makes it functionally equivalent to the other platforms, even though everything is still driven though callbacks.
There wasn't a clear shutdown signal being sent to the request reading task, and disconnect errors weren't being handled properly. This fixes all issues with disconnecting and reconnecting in wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability for
pliantdb-clientto connect over WebSockets in WebAssembly. Closes #58.Investigate unit testingSplit off to Figure out unit tests for wasm client #63The nice thing is that the example doesn't need any special includes for
PliantDbto work, so there isn't anything special to document about project setup.