Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a reduce API #23

Closed
ecton opened this issue Oct 27, 2021 · 0 comments
Closed

Implement a reduce API #23

ecton opened this issue Oct 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ecton
Copy link
Member

ecton commented Oct 27, 2021

The last major feature for BonsaiDb that we need is to consume the new features implemented in #19 and #21 is the ability to compute a reduced value over a partial scan of a tree. Originally when implementing the underlying features, I envisioned "reduce" being a BonsaiDb views feature, not something that Nebari itself would offer. However, upon more thought, it definitely would be a great feature to have in this crate.

The API should look something like this:

impl TreeFile {
    fn reduce<R: RangeBounds<Buffer>>(&self, range: Buffer) -> Root::ReducedIndex {}
}

That signature is pseudo-code, and probably requires additional parameters.

@ecton ecton added the enhancement New feature or request label Oct 27, 2021
@ecton ecton added this to To do in Khonsu Labs Roadmap via automation Oct 27, 2021
ecton added a commit to khonsulabs/bonsaidb that referenced this issue Mar 1, 2022
As I implemented this, I realized it wouldn't be as efficient as it
could be until this ticket is completed: khonsulabs/nebari#23
@ecton ecton closed this as completed in 4a67862 Mar 12, 2022
Khonsu Labs Roadmap automation moved this from To do to Done Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant