Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for glslang/MachineIndependent/unistd.h? #86

Closed
mgadams opened this issue Oct 26, 2015 · 3 comments
Closed

Reason for glslang/MachineIndependent/unistd.h? #86

mgadams opened this issue Oct 26, 2015 · 3 comments

Comments

@mgadams
Copy link
Contributor

mgadams commented Oct 26, 2015

Can anybody shed any light on why there's an empty unistd.h in glslang/MachineIndependent/ ? From a quick grep, I don't see that actually get used anywhere in glslang.

This is causing problems when being built into a test app in an environment where we can't use the CMake build system. This empty file is then getting picked up due to include path sharing, breaking other code which needs a real unistd.h.

Thanks,
//Mark

@xorgy
Copy link
Contributor

xorgy commented Oct 27, 2015

Seems it's been there since 3DLabs last touched glslang in 2005.

In that import, the README.txt talks about why the header is there.

2.  You may have a missing header file, unistd.h.  Create an empty one in
some standard devstudio or SDK system include directory.  (Bison/flex
generate a #include <unistd.h>, this makes them happy.)

I don't think this happens anymore, so it should be safe to remove unistd.h. Though I have not tested flex, and I have not tested versions of bison older than than 3.0.4.

@mgadams
Copy link
Contributor Author

mgadams commented Oct 27, 2015

I think you're correct. The one platform I'd be slightly concerned about would be Windows, and I confirmed that the bison.exe in the tools directory doesn't generate code including unistd.h.

Given that, I've created pull request #88 to remove it.

@johnkslang
Copy link
Member

I think this is a problem from 2003 that does not exist in 2015. Fixed with pull request #88.

(Flex is no longer part of glslang.)

I suspect the existing MSVC project files should also be removed. Only CMake is being maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants