-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<model-viewer> tag not rendering properly in title #29
Comments
@Khronoswebmaster The data file does not seem to be reflected in the deployed state. I think this happened automagically during the first deployment, and I'm not aware of any update process here. The data file that is pulled from the deployed state is (There are some possible hacky solutions for this, and some caveats, but before I start speculating: ) Is there any process to dedicatedly trigger an update of the deployed state? (An aside: The project explorer could also be listed at http://github.khronos.org/ , but that's not critical right now...) |
Not sure I understand the question. The data file |
The file http://github.khronos.org/glTF-Project-Explorer/data/glTF-projects-data.json (which seems to exist - at least, it is shown for me when I click the link) is different from the file in the repo, and there has to be some sort of update. But according to #36 (comment) , this is done with a "semi-manual" process, and Adam (weegeekps) mentioned that he'd do it, so there may not be an immediate action for the Khronos webmaster. (And maybe this issue can be closed again then - sorry, I must admit that I don't know much about certain parts of (web) infrastructures, so I might have bothered you unnecessarily...) |
The issue is that we don't currently have a way of automatically performing the deployment. Everything is actually in place for doing so, except that we don't have a runner. Our original plan was to use GitHub Actions but it doesn't look like that's enabled for Khronos Repos. Maybe you can look into that @Khronoswebmaster? In the meantime, we can do a manual deployment by executing |
If Travis-ci would be helpful, I will enable it. You would need to figure out what the .travis.yml should contain. |
I think Travis CI would work great. I will start investigating what we need in the travis config for our repo. |
If you add the Travis CI and trigger a build you should be all set. Travis-CI.com has you listed as waiting for the first build. |
If I understood this correctly, then the build process is set up. (This issue was only about a somewhat unrelated, smaller issue - so if there are points to discuss regarding the build, it could be done in another issue). |
On the Project Explorer Page page the <model-viewer> is rendering as <model-viewer> in the title. It appears to render correctly further down on the page when mentioned in the description for three.js glTF loader.
The text was updated successfully, but these errors were encountered: