Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination #5

Open
weegeekps opened this issue Oct 4, 2019 · 0 comments
Open

Pagination #5

weegeekps opened this issue Oct 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@weegeekps
Copy link
Contributor

Right now performance is fine but not great. Depending on the computer, initial load and clearing all filters is noticeably slow, taking about 250ms-400ms in my own testing. I've tracked this down to DOM repaint performance; we have a lot of nodes on the page, so we should try to reduce that count.

I'm currently favoring pagination to limit the number of results we show at once. It tends to be more accessible than infinite scrolls and is easier to implement and maintain. A count of about 30 records per page seems good to me, but an open question I have is if we should have the ability to allow users to adjust this?
@weegeekps weegeekps added the enhancement New feature or request label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weegeekps