You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at the brdfLUT.png map (the original one, not the modified one in #18), @abwood and I experimented with contrast-enhancing the image to look for irregularities. All four borders of the image have 1-pixel-thick discontinuous irregularities. In a few cases, such as the lower-right and lower-left corners, these are visible to a trained naked eye. But with contrast adjustments, a 1-pixel border around the entire image becomes visible.
I will try to post some screenshots of these findings later today or tomorrow. In the meantime, I'm curious how this image was created, if it can be regenerated, or if the repo here could actually generate this image with a pre-render pass at runtime?
I initially was using a BRDF LUT generated from IBLBaker, but it caused odd banding artifacts, so I found one from another source.
Since there is an issue in confidence with obtaining a LUT from another source, I think we should just generate one ourselves. Unreal Engine explains the details in their Real Shading in Unreal Engine 4 paper. Their explanation on specular BRDF integration starts at page 6.
@moneimne I found a post on gamedev where someone attempts to port the shaders from your link of the UE4 paper over to GLSL. But they're using uint and bitwise operators, which doesn't work in WebGL 1. Maybe WebGL 2 supports it?
Looking at the
brdfLUT.png
map (the original one, not the modified one in #18), @abwood and I experimented with contrast-enhancing the image to look for irregularities. All four borders of the image have 1-pixel-thick discontinuous irregularities. In a few cases, such as the lower-right and lower-left corners, these are visible to a trained naked eye. But with contrast adjustments, a 1-pixel border around the entire image becomes visible.I will try to post some screenshots of these findings later today or tomorrow. In the meantime, I'm curious how this image was created, if it can be regenerated, or if the repo here could actually generate this image with a pre-render pass at runtime?
/cc @moneimne
The text was updated successfully, but these errors were encountered: