Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add continuous integration #62

Closed
4 tasks done
kpet opened this issue Jun 19, 2019 · 1 comment
Closed
4 tasks done

Add continuous integration #62

kpet opened this issue Jun 19, 2019 · 1 comment
Assignees
@kpet

Comments

@kpet
Copy link
Contributor

kpet commented Jun 19, 2019 •
edited
Loading

  • Run the header generation script
  • Build the tests
  • Run the tests
  • Anything else?
@kpet kpet mentioned this issue Jul 19, 2019
Merged
@kpet kpet self-assigned this Jul 19, 2019
kpet added a commit that referenced this issue Sep 16, 2019
@kpet
Fix failing test and enable testing in Travis
2dd1ece 
Since we build with CL_HPP_MINIMUM_OPENCL_VERSION defined to 100,
the bindings are querying the platform to decide whether to use
clCreateCommandQueue or clCreateCommandQueueWithProperties. We
thus need to make the stub function for clGetPlatformInfo report
2.0 when building with CL_HPP_TARGET_OPENCL_VERSION >= 200 to
mirror the queue creation function check.

Contributes to #62.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
kpet added a commit that referenced this issue Sep 16, 2019
@kpet
Fix failing tests and enable testing in Travis
74562bc 
Since we build with CL_HPP_MINIMUM_OPENCL_VERSION defined to 100,
the bindings are querying the platform to decide whether to use
clCreateCommandQueue or clCreateCommandQueueWithProperties. We
thus need to make the stub function for clGetPlatformInfo report
2.0 when building with CL_HPP_TARGET_OPENCL_VERSION >= 200 to
mirror the queue creation function check.

Also allow calls to clCreateContextFromType with no properties on
Apple platforms to mirror the logic in the bindings.

Contributes to #62.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
@kpet kpet mentioned this issue Sep 16, 2019
Merged
bashbaug pushed a commit that referenced this issue Sep 20, 2019
@kpet @bashbaug
Fix failing tests and enable testing in Travis (#67)
abe1273 
Since we build with CL_HPP_MINIMUM_OPENCL_VERSION defined to 100,
the bindings are querying the platform to decide whether to use
clCreateCommandQueue or clCreateCommandQueueWithProperties. We
thus need to make the stub function for clGetPlatformInfo report
2.0 when building with CL_HPP_TARGET_OPENCL_VERSION >= 200 to
mirror the queue creation function check.

Also allow calls to clCreateContextFromType with no properties on
Apple platforms to mirror the logic in the bindings.

Contributes to #62.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
@kpet
Copy link
Contributor Author

kpet commented Oct 23, 2019

We now have basic continuous integration up and running. I'm going to close this. I've created #78 to try and capture a detailed list of the configurations that we want to test.

@kpet kpet closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpet kpet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpet