Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spvDiagnosticDestroy should be safe to call on nullptr #62

Closed
dneto0 opened this issue Jan 11, 2016 · 0 comments
Closed

spvDiagnosticDestroy should be safe to call on nullptr #62

dneto0 opened this issue Jan 11, 2016 · 0 comments
Assignees
@dneto0

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Jan 11, 2016

That's a useful behaviour, to simplify client code.
The current implementation is already safe in this way.
Need to document it and write tests for it.
@dneto0 dneto0 mentioned this issue Jan 11, 2016
Merged
@dneto0 dneto0 self-assigned this Jan 11, 2016
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Jan 11, 2016
@dneto0
spvDiagnosticDestroy is safe to call on nullptr
290a88f 
Fixes KhronosGroup#62
@dneto0 dneto0 mentioned this issue Jan 11, 2016
Merged
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Jan 11, 2016
@dneto0
spvDiagnosticDestroy is safe to call on nullptr
59f4100 
Fixes KhronosGroup#62
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Jan 11, 2016
@dneto0
spvDiagnosticDestroy is safe to call on nullptr
5d30edb 
Fixes KhronosGroup#62
cnorthrop pushed a commit to cnorthrop/SPIRV-Tools that referenced this issue May 23, 2017
@Qining
Squash and merge KhronosGroup#62: Add SetSuppressWarnings() to libsha…
98324ad 
…derc
dgkoch pushed a commit to dgkoch/SPIRV-Tools that referenced this issue Nov 21, 2018
@johnkslang
Merge pull request KhronosGroup#62 from antiagainst/fix-extensions
9f6846f 
Add missing extension/capability requirements for some symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dneto0 dneto0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dneto0