fix: normal textures in glTF exported with wrong color space, builtin…

… texture paths not correct
KhronosGroup · Jun 1, 2022 · 56502fa · 56502fa
1 parent fbccd83
commit 56502fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/UnityGLTF/Assets/UnityGLTF/Editor/Scripts/GLTFExportMenu.cs b/UnityGLTF/Assets/UnityGLTF/Editor/Scripts/GLTFExportMenu.cs
@@ -15,9 +15,10 @@ public static string RetrieveTexturePath(UnityEngine.Texture texture)
 	    {
 	        var path = AssetDatabase.GetAssetPath(texture);
 	        // texture is a subasset
-	        if(AssetDatabase.GetMainAssetTypeAtPath(path) != typeof(Texture2D))
+	        if (AssetDatabase.GetMainAssetTypeAtPath(path) != typeof(Texture2D))
 	        {
 		        var ext = System.IO.Path.GetExtension(path);
+		        if (string.IsNullOrWhiteSpace(ext)) return texture.name + ".png";
 		        path = path.Replace(ext, "-" + texture.name + ext);
 	        }
 	        return path;

diff --git a/UnityGLTF/Assets/UnityGLTF/Runtime/Scripts/GLTFSceneExporter.cs b/UnityGLTF/Assets/UnityGLTF/Runtime/Scripts/GLTFSceneExporter.cs
@@ -786,7 +786,7 @@ private void ExportMetallicGlossTexture(Texture2D texture, string outputPath, bo
 		/// <param name="outputPath">The location to export the texture</param>
 		private void ExportNormalTexture(Texture2D texture, string outputPath)
 		{
-			var destRenderTexture = RenderTexture.GetTemporary(texture.width, texture.height, 0, RenderTextureFormat.ARGB32, RenderTextureReadWrite.Linear);
+			var destRenderTexture = RenderTexture.GetTemporary(texture.width, texture.height, 0, RenderTextureFormat.ARGB32, RenderTextureReadWrite.sRGB);
 			Graphics.Blit(texture, destRenderTexture, _normalChannelMaterial);
 			WriteRenderTextureToDiskAndRelease(destRenderTexture, outputPath, false);
 		}