fix: conversion with _EMISSION keyword off was still setting emissive…

… values (#86)
KhronosGroup · May 24, 2023 · ec15f26 · ec15f26
1 parent 041b223
commit ec15f26
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/UnityGLTF/Assets/UnityGLTF/Editor/Scripts/ShaderGraph/ShaderConverters.cs b/UnityGLTF/Assets/UnityGLTF/Editor/Scripts/ShaderGraph/ShaderConverters.cs
@@ -107,6 +107,14 @@ private static bool ConvertStandardAndURPLit(Material material, Shader oldShader
 			var occlusionStrength = material.GetFloat(_Strength, 1);
 			var emission = material.GetTexture(_EmissionMap, null);
 			var emissionColor = material.GetColor(_EmissionColor, Color.black);
+
+			// if emission is OFF we don't want to set it to ON during conversion
+			if ((oldShader.name == StandardShader || oldShader.name == URPLitShader) && !material.IsKeywordEnabled("_EMISSION"))
+			{
+				emission = null;
+				emissionColor = Color.black;
+			}
+
 			var cutoff = material.GetFloat(_Cutoff, 0.5f);
 
 			var isCutoff = material.IsKeywordEnabled("_ALPHATEST_ON") ||