Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Specular Glossiness Physically Based Rendering #5

Closed
robertlong opened this issue Mar 9, 2017 · 2 comments
Closed

Add Support for Specular Glossiness Physically Based Rendering #5

robertlong opened this issue Mar 9, 2017 · 2 comments
Labels
extension

Comments

@robertlong
Copy link
Contributor

This is the only documentation I can find on this so far: https://github.com/sbtron/glTF/tree/KHRpbrSpecGloss/extensions/Khronos/KHR_materials_pbrSpecularGlossiness#additional-maps

I'd be nice to support this workflow, but I'd like to hold off until it's finalized.
@jm991
Copy link
Contributor

jm991 commented Oct 6, 2017

Hi,

Could I have access to make pull requests? I have forked the repository and added a prototype of loading spec/gloss for KHR_materials_pbrSpecularGlossiness: https://github.com/jm991/UnityGLTF/commits/master

I'd like to get feedback on my implementation and work with the group to get spec/gloss supported in master.

Thank you!
John

image

@sbtron
Copy link
Contributor

sbtron commented Nov 15, 2017

Added in #74

@sbtron sbtron closed this as completed Nov 15, 2017
hybridherbst referenced this issue in prefrontalcortex/UnityGLTF Dec 12, 2019
@cedricpinson
Merge pull request #5 from sketchfab/feature/adds-banner_D3D-4591
b4380a6 
[#D3D-4591] Adds store banner in plugin
js-dignitas added a commit to js-dignitas/UnityGLTF that referenced this issue Oct 19, 2021
@js-dignitas
Pull request KhronosGroup#5: Feature/ARES-1936 baseglobe
eb52e11 
Merge in ARES/ares.unity_gltf from feature/ARES-1936-baseglobe to ares

* commit '9d38f64bf7a1bacb436bdcb88d8ce1e463437540':
  ARES-1936 Material for unlit
  ARES-1936 Fix material bug that prevented textures from loading for BaseGlobe
hybridherbst added a commit that referenced this issue Apr 8, 2022
@hybridherbst
Merge pull request #5 from D33pTh0ught/unlit-support
9da5a62 
Implemented support for KHR_materials_unlit extension
hybridherbst added a commit that referenced this issue Apr 8, 2022
@hybridherbst
cosmetics PR #5
aa9f300
github-actions bot pushed a commit to Rhinox-Training/UnityGLTF that referenced this issue Nov 9, 2022
@hybridherbst
Merge pull request KhronosGroup#5 from D33pTh0ught/unlit-support
40eb353 
Implemented support for KHR_materials_unlit extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbtron @robertlong @jm991