-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WIN32 .lib
installs
#182
Comments
Layers should be `MODULE`s not `SHARED` They are only meant to be loaded via runtime means like dlopen. The main practical effect of this is that CMake now doesn't install a corresponding .lib file. Since users aren't trying to link against the library. closes #182
Layers should be `MODULE`s not `SHARED` They are only meant to be loaded via runtime means like dlopen. The main practical effect of this is that CMake now doesn't install a corresponding .lib file. Since users aren't trying to link against the library. closes #182
The latest SDK build still shows issues: http://erusea:8080/view/Manual/job/manual-sdk/529/console
I observe that I also note that the 32-bit |
I just checked the build logs from github actions: https://github.com/KhronosGroup/Vulkan-ExtensionLayer/actions/runs/4690667744/jobs/8314079421 No
Sure but why? |
Just had Karen explain to me the rational. I have a new PR up that will remove 32 bit support. |
We debated in an SDK planning video meeting the need for 32-bit. Recalling my notes, the general thoughts went (:heavy_plus_sign: marks arguments for 32-bit support, :heavy_minus_sign: marks arguments against):
IIRC, we decided to ship 64-bit only for now, and reconsider if and when someone complains. |
The Windows
install
target currently installs various.lib
files. It should not, as these are not shipped by the SDK.The SDK is also planning on not shipping 32-bit artifacts for the
VK_LAYER_KHRONOS_shader_object
(though it will continue to ship 32-bitVK_LAYER_KHRONOS_synchronization2
artifacts). So the 32-bitinstall
target should not shipBin\VkLayer_khronos_shader_object.dll
,Bin\VkLayer_khronos_shader_object.json
, or,Bin\VkLayer_khronos_shader_object.pdb
.The text was updated successfully, but these errors were encountered: