-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default line width causes drawState error #64
Comments
Unfortunately, vk.xml does not specify any defaults. |
Yeah, that makes sense. Unfortunately, as a default, it's not valid at least on this hardware. |
During the last Khronos Vulkan DevU event the idea came up to something like a 'vk_defaults.xml' file where one could define multiple useful default parameters for CreateInfo structs. This file could be used to create a factory library which would allow you to write something like:
The idea is to have reasonable defaults for all objects where applicable with the option for developers to define their own default values. One question which comes up if Vulkan-Hpp should use this file too for the default values. Since this will affect source code compatibility unfortunately I'd have to say no. |
@mtavenrath That's an awesome idea. If you are worried about source code compatibility, I guess I could relate. But: 1/ Bump major version? |
Default values should be implemented outside of Vulkan-Hpp in a factory-like utility library. Closing. |
Vulkan-Hpp/vulkan/vulkan.hpp
Line 7079 in 43ec5d8
causes
[T+0.098 main ERROR] DS Attempt to set lineWidth to 0.000000 but physical device limits line width to between [0.500000, 10.000000]!
Is there a reasonable default (e.g. 1?)
The text was updated successfully, but these errors were encountered: