-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader should issue informational message when loading each layer #123
Comments
Comment by mark-lunarg (MIGRATED) @krOoze, there is already a facility in the loader for something close to this -- you can set One minor issue related to spitting out a perf-warning with the above message is that each of the layers is independent and shares no data, so each layer would have to output its own message. |
Comment by krOoze (MIGRATED) @mark-lunarg That just seems to register another callback with all flags enabled. |
Comment by mark-lunarg (MIGRATED) Hi again, we talked about it here and were hoping to get a better idea about which problem(s) you are hoping to solve, taking into account that the loader debug environment setting does indicate which layers are loaded. We're open to the suggestion but need to justify the effort. Thanks! |
Comment by krOoze (MIGRATED) Use cases:
Currenty I have the options:
Those options sound inadequate for something as this that should be simple. -> the suggestion above to make an intro |
@karl-lunarg I already listed use cases in the previous post, but mainly:
nr. 1 somewhat implies it should be Though I guess not an end of the world if it is INFO. One would have to register separate messanger and filter the message out by some identifier (so at least add well documented message id, I guess). Though my hope is new users asking for help would copy-paste this warning, without the community having to ask each time whether they have layers enabled. But yea, name + path (all are same path usually, so could be there only once). Preferrably in single summary Oh, and version. That is useful to spot outdated SDK, when helping others. |
Now, set VK_LOADER_DEBUG=layer and you should get information like:
Of course, it should show no layers if none are enabled. I hope this satisfies your needs. This information should also be outputted when VK_LOADER_DEBUG=all, but that's kind of messy and overwhelming. My problem with associating this with PERFORMANCE_WARNING is that there are layers that are always enabled. The various GPU sorting layers by the IHVs for example. So you would always get this message. I'd prefer to keep it something like this. I'm willing to make it show up for both, though, if it's important enough. |
I also now output more information. For each layer I output:
This is all enabled with |
@MarkY-LunarG The solution is kinda not in the spirit of why it is needed. My intention here is not to debug the loader (as the enabling mechanism would suggest). My intention here is to know whether the app is (or isn't) in debug mode, an preferrably in as foolproof and implicit way as possible. I care about virtually none of the above layer information. Regardless, now that we touched on it, that is perhaps information that should be available programatically and through |
Yeah, the concern is how do you define "debug mode" for an application? Enabling validation layers, using a debug loader, forcing VK_LAYER_PATH/VK_ICD_FILENAMES. All of that could be considered debug mode. My concern is that's really vague and hard to track. I've re-opened this for now so we can think about it some more, though. Maybe we can think of something. |
@MarkY-LunarG It's not that vague. If at least
That too perhaps, but it is diminishing returns. Less people use debug build of loader.
Perhaps useful, but for diferent and nicher reasons. |
This is actually handled by the |
I didn't say loader needs to do anything. The Issue just got migrated here for some reason... |
I think tooling info extension solves this gap pretty well. I will close this issue, feel free to reopen it, or ask to move it to a better location if you feel this is in err. |
In order to provide run-time confirmation of layer configuration, the loader should emit an INFO message for each layer loaded, including at least name and path.
@krOoze -- What in addition is needed to meet your use cases below?
Moved to loader as it doesn't abuse the
VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT
, and addresses the required use cases belowIssue by krOoze (MIGRATED)
Wednesday Nov 15, 2017 at 16:14 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#2207
Original Text:
Enabled validation layers should give performance warning.
The primary motivation is that I would want a feedback from the implementation, that I enabled the layers properly and my validation environment works. The message could be something like:
The reason for using
VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT
is because it technically is a performance drain. (And it is simpler to have this enabled, otherwise it could beINFO
, but that would require filtering out all the other unwantedINFO
messages.)It probably have to be logged twice if the user uses both the temporary and regular debug callback. It is a stretch though to pass the temporary callback as a
PERFORMANCE_WARNING
...The text was updated successfully, but these errors were encountered: