Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance creation should have validation layers applied to it. #30

Closed
jherico opened this issue Jan 6, 2020 · 0 comments · Fixed by #60
Closed

Instance creation should have validation layers applied to it. #30

jherico opened this issue Jan 6, 2020 · 0 comments · Fixed by #60

Comments

@jherico
Copy link
Contributor

jherico commented Jan 6, 2020

The code in vkb::Instance::Instance constructs a VkInstance and then (when either VKB_DEBUG or VKB_VALIDATION_LAYERS are defined) populates a VkDebugReportCallbackCreateInfoEXT and creates a debug report callback.

However, the VK_EXT_debug_report extension was specifically designed to ensure that validation could be applied even to instance creation.

if VKB_DEBUG or VKB_VALIDATION_LAYERS are defined, then the VkDebugReportCallbackCreateInfoEXT declaration should be before instance creation code, and the VkDebugReportCallbackCreateInfoEXT structure should be set as the pNext of VkInstanceCreateInfo

@jherico jherico mentioned this issue Jan 7, 2020
13 tasks
@ghost ghost closed this as completed in #60 Feb 20, 2020
@gary-sweet gary-sweet mentioned this issue Apr 8, 2020
12 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant