Skip to content

Commit

Permalink
Update core/src/impl/Kokkos_Profiling.hpp
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
  • Loading branch information
khuck and masterleinad committed Apr 18, 2024
1 parent c3d583b commit 50fbbc2
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions core/src/impl/Kokkos_Profiling.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -304,24 +304,6 @@ auto tune_policy(const size_t, const std::string&, const ExecPolicy& policy,
return policy;
}

/**
* Tuning for parallel_fors and parallel_scans is a fairly simple process.
*
* Tuning for a parallel_reduce turns out to be a little more complicated.
*
* If you're tuning a reducer, it might be a complex or a simple reducer
* (an example of simple would be one where the join is just "+".
*
* Unfortunately these two paths are very different in terms of which classes
* get instantiated. Thankfully, all of this complexity is encoded in the
* ReducerType. If it's a "simple" reducer, this will be Kokkos::InvalidType,
* otherwise it'll be something else.
*
* If the type is complex, for the code to be generally right you _must_
* pass an instance of that ReducerType to functions that determine
* eligible team sizes. If the type is simple, you can't construct one,
* you use the simpler 2-arg formulation of team_size_recommended/max.
*/

struct SimpleTeamSizeCalculator {
template <typename Policy, typename Functor, typename Tag>
Expand Down

0 comments on commit 50fbbc2

Please sign in to comment.