Skip to content

Commit

Permalink
mm: use pagevec_lookup_range_tag() in __filemap_fdatawait_range()
Browse files Browse the repository at this point in the history
Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() as it is
interested only in pages from given range.  Remove unnecessary code
resulting from this.

Link: http://lkml.kernel.org/r/20171009151359.31984-11-jack@suse.cz
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: khusika <khusikadhamar@gmail.com>
  • Loading branch information
jankara authored and khusika committed Aug 9, 2018
1 parent e648622 commit c2d0d2a
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,19 +343,17 @@ int filemap_fdatawait_range(struct address_space *mapping, loff_t start_byte,
goto out;

pagevec_init(&pvec, 0);
while ((index <= end) &&
(nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
PAGECACHE_TAG_WRITEBACK,
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1)) != 0) {
while (index <= end) {
unsigned i;

nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
end, PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE);
if (!nr_pages)
break;

for (i = 0; i < nr_pages; i++) {
struct page *page = pvec.pages[i];

/* until radix tree lookup accepts end_index */
if (page->index > end)
continue;

wait_on_page_writeback(page);
if (TestClearPageError(page))
ret = -EIO;
Expand Down

0 comments on commit c2d0d2a

Please sign in to comment.