Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited English file #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TantumErgo
Copy link

@TantumErgo TantumErgo commented Sep 5, 2019

Issue: [#167 ]

Description:

The file _18n/en.yml was checked for typos and grammatical errors. Capitalization of proper nouns was not for the most part edited. Additional comments are preceded by the # as is proper in YAML files for comments. See the comments for additional information on other edits that were not possible to make without details.

Testing steps:

Explain how to test your PR manually

Checklist:

  • Spec tests are passing on CI
  • rake lint does not return any warnings
  • Tested manually

Screenshots:

Provide screenshots of implemented functionality if situation required

First run-through. Need to go back and check all edits.

Did not edit slang use or lack of capitalization of proper nouns throughout the text.
Checked all edits made in the first run-through.

Ready for pull request.
@khusnetdinov
Copy link
Owner

@TantumErgo Can I merge? It was finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants