Fix memory leaks and other bugs #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 13, 2020 00:28
I only meant to fix the g_variant_unref warning, but fixing all of them works too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes memory leaks (including fixing #20), uses
g_hash_table_new_fullinstead ofg_hash_table_newto simplify some memory management, removes a bunch of annoyingGLib-CRITICALerrors due to an unset GVariant and use-after-free's, and replacesmanager_default_adapterwithmanager_find_adapter(..., NULL, ...).It also fixes sdptool when it isn't in /bin; it seems to have trouble parsing its output but it can find the binary.