vmlatency: Fix latency comparison #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the config.Config struct, holds a field named: `DesiredMaxLatencyMilliseconds`. Change this field type to `time.Duration` and remove the `Milliseconds` suffix, in order to better compare it with the actual measured latency during `Checkup.Run()`. Signed-off-by: Orel Misan <omisan@redhat.com>
Change the error message format to use the string format of `time.Duration` in order to improve readability. Signed-off-by: Orel Misan <omisan@redhat.com>
Currently, `millisecondsPrefix` is used only as a suffix. Change its name accordingly. Signed-off-by: Orel Misan <omisan@redhat.com>
orelmisan
force-pushed
the
fixclatencycomparison
branch
from
0f23c64
to
b9d5f89
Compare
|
Change: Added "vmlatency" prefix to commit message subject. |
ormergi
reviewed
Jan 29, 2023
| return Config{}, fmt.Errorf("%q parameter is invalid: %v", DesiredMaxLatencyMillisecondsParamName, err) | ||
| } | ||
|
|
||
| newConfig.DesiredMaxLatency = time.Duration(rawDesiredMaxLatencyMilliseconds) * time.Millisecond |
There was a problem hiding this comment.
How about using the built-in ParseDuration?
cost MillisecondUnit= "ms"
desiredMaxLatency, err := time.ParseDuration(rawDesiredMaxLatencyMilliseconds + MillisecondUnit)
There was a problem hiding this comment.
This is a great idea (that maybe could be implemented in the other checkups as well).
The problem is that it requires more changes to the unit test.
I prefer to do it in a follow-up PR.
There was a problem hiding this comment.
either are ok by my book
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the actual measured latency is less than 1ms, it is considered as 0ms.
This created a small bug[1] when the max desired latency was 0ms.
Improve the comparison of the max desired latency and the actual measured latency.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2156392