Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Make checkup and traffic-gen independent #112

Merged

Conversation

orelmisan
Copy link
Member

Currently, the checkup image build and push targets are dependent on the traffic generator image matching targets.

This dependency disables the ability to build or push only the checkup image.

Make the build and push targets of the checkup image independent of the traffic generator image targets.

Currently, the checkup image `build` and `push` targets are
dependent on the traffic generator image matching targets.

This dependency disables the ability to build or push only the
checkup image.

Make the `build` and `push` targets of the checkup image
independent of the traffic generator image targets.

Signed-off-by: Orel Misan <omisan@redhat.com>
@orelmisan orelmisan requested a review from RamLavi July 2, 2023 09:19
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@orelmisan orelmisan merged commit 0883361 into kiagnose:main Jul 3, 2023
5 checks passed
@orelmisan orelmisan deleted the separate_traffic_gen_build_and_push branch July 3, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants